This repository has been archived by the owner on Apr 6, 2024. It is now read-only.
Fix duplicate tag bug, error message specificity issue and standardize messages for notes feature
#208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #208 +/- ##
============================================
+ Coverage 82.50% 82.69% +0.18%
- Complexity 753 758 +5
============================================
Files 99 99
Lines 2327 2329 +2
Branches 261 264 +3
============================================
+ Hits 1920 1926 +6
+ Misses 339 335 -4
Partials 68 68
☔ View full report in Codecov by Sentry. |
limjunxian1
changed the title
limjunxian1
changed the title
notes feature
lordidiot
approved these changes
Nov 11, 2023
| Balance balance = personToEdit.getBalance(); | ||
|
|
||
| Person updatedPerson = new Person(updatedName, updatedPhone, updatedEmail, updatedAddress, updatedBirthday, | ||
| updatedLinkedin, updatedSecondaryEmail, updatedTelegram, updatedTags, id, notes, balance); | ||
| updatedLinkedin, updatedSecondaryEmail, updatedTelegram, updatedTags, id, avatar, notes, balance); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145, and addresses the invalid index in #196 for
addalt,editanddeleteand notes feature. It also fixes a bug that a photo is removed wheneditcommand is executed due to the changes made to how photo is rendered for each person.In addition, closes #181 and closes #193